Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor satisfiability to independent set reduction #80

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

GiggleLiu
Copy link
Owner

No description provided.

@GiggleLiu
Copy link
Owner Author

@SciCodePhy I refactored the code a bit, please make sure all the changes are correct.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (b90737a) to head (ae9768f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   93.81%   93.54%   -0.27%     
==========================================
  Files          30       30              
  Lines        1244     1177      -67     
==========================================
- Hits         1167     1101      -66     
+ Misses         77       76       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SciCodePhy
Copy link
Collaborator

SciCodePhy commented Aug 15, 2024

@SciCodePhy I refactored the code a bit, please make sure all the changes are correct.

@GiggleLiu I implemented similar things on another branch and implemented the extract_multiple_solutions (not pushed yet), so I will integrate my code into this PR.

Besides, I think it might be better to assign random Bool values to missed literals in the assignment rather than assigning false to all the missed literals. I will modify this part.

The "extract_multiple_solutions" will be moved to another PR.

@SciCodePhy
Copy link
Collaborator

Implemented:

  • Stable return for evaluate function of IndependentSet problem;
  • Modify the refactored extract_solution for "SAT => Independent Set" reduction;
  • Include "extract_multiple_solutions" function for "SAT => Independent Set" reduction;

Next Step:

  • "extract_multiple_solutions" function will be included for other reductions.

@SciCodePhy SciCodePhy merged commit d3b7617 into main Aug 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants