Fix crash when image path contains encoded URI #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct the way to convert a URI to a path - Do not try to convert to a path if a variable is already a path - Do not name 'uri' if a variable contains a path
GijsGoudzwaard
force-pushed
the
master
branch
2 times, most recently
from
c46772c to
6cfacdc
Compare
|
Looks good, thank you for the continued help squashing those pesky bugs! |
GijsGoudzwaard
added a commit
that referenced
this pull request
Aug 23, 2024
Fix crash when image path contains encoded URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24