Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize examples and use them as tests #108

Merged
merged 5 commits into from
Feb 28, 2015
Merged

Modernize examples and use them as tests #108

merged 5 commits into from
Feb 28, 2015

Conversation

jiahao
Copy link
Contributor

@jiahao jiahao commented Feb 26, 2015

This PR updates the examples in the examples/ directory so that they run on
modern versions of Julia and Compose. Additionally, tests have been added which
run all the examples and compares the generated output with cached output.

I've also included a Travis configuration file so that if you want to flip the
switch, Compose.jl can start to have CI tests and coverage data.

Additionally, there are several spelling corrections, formatting adjustments,
and an update to the license file.

Caveat: I've had to guess what some of the examples do in order to modernize
them.

Implementation note:

The tests do not use Base.Test. Instead, runtests.jl keeps track of any
files that differ from the cached output and outputs a list of different files.
If diff is available locally, also prints out the diff to facilitate
comparison. The files that differ are not automatically deleted from the
test subdirectory where they are generated.

@shashi
Copy link
Collaborator

shashi commented Feb 26, 2015

💯

dcjones added a commit that referenced this pull request Feb 28, 2015
Modernize examples and use them as tests
@dcjones dcjones merged commit a6e4dbb into GiovineItalia:master Feb 28, 2015
@dcjones
Copy link
Collaborator

dcjones commented Feb 28, 2015

Awesome, thanks!

I'm going to miss all my misspellings though. I'll try to add more in future commits.

@jiahao jiahao deleted the cjh/update-examples branch February 28, 2015 22:23
@jiahao
Copy link
Contributor Author

jiahao commented Mar 1, 2015

It's more fun to cöopt obsolete diacritics :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants