Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introspect: add "R" for rectangle, "C" for circle, etc. #144

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Sep 2, 2015

I'm hoping this will be helpful as I dig into the architecture.

I can't distinguish vcenter, vtop, and vbottom, is this a bug?

dcjones added a commit that referenced this pull request Sep 2, 2015
introspect: add "R" for rectangle, "C" for circle, etc.
@dcjones dcjones merged commit a1d8fa5 into master Sep 2, 2015
@dcjones
Copy link
Collaborator

dcjones commented Sep 2, 2015

Thanks, this looks nice.

Vertical alignment works for me on PNG and SVG, but it could be at the whims of the browser for SVG or cairo's ability to compute text sizes for cairo backends.

If you're digging into the architecture, you should maybe take a look at the measures branch, which is work that @shashi and I did that simplifies and speeds things up quite a bit. I'm waiting to 0.4 to be released to merge it, because it assumes efficient tuples.

@shashi
Copy link
Collaborator

shashi commented Sep 2, 2015

I wonder if JuliaLang/julia#11187 thwarts our plans though

@dcjones
Copy link
Collaborator

dcjones commented Sep 2, 2015

You're worried that passing all tuples by reference will wipe out any performance improvement?

@shashi
Copy link
Collaborator

shashi commented Sep 2, 2015

Yeah, could make it worse. But I haven't seen the numbers yet.

@dcjones
Copy link
Collaborator

dcjones commented Sep 7, 2015

@shashi I benchmarked an order-11 sierpinski triangle on measures.

On julia master:
2.526038 seconds (9.21 M allocations: 366.310 MB, 2.12% gc time)

One commit before JuliaLang/julia@f2cce89
2.273112 seconds (9.21 M allocations: 366.310 MB, 1.98% gc time)

So it is slower, but not dramatically. Compare this to master:

julia master:
8.549056 seconds (36.14 M allocations: 983.982 MB, 1.75% gc time)

JuliaLang/julia@f2cce89 ~ 1
7.724505 seconds (36.14 M allocations: 983.982 MB, 1.24% gc time)

@shashi
Copy link
Collaborator

shashi commented Sep 7, 2015

Nice! The change doesn't matter much at all. And whoa 9.21M allocations.

@dcjones
Copy link
Collaborator

dcjones commented Sep 7, 2015

Yeah, that seems a little crazy: 9.21e6 / 3^11 -> 52 allocations per triangle drawn! Clearly there's some more room for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants