Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still to do #1192

Open
4 of 6 tasks
bjarthur opened this issue Sep 14, 2018 · 13 comments
Open
4 of 6 tasks

still to do #1192

bjarthur opened this issue Sep 14, 2018 · 13 comments

Comments

@bjarthur
Copy link
Member

bjarthur commented Sep 14, 2018

@Mattriks
Copy link
Member

Just wondering is there a link to some recent discussion about point 5? e..g #910, #926

@tlnagy
Copy link
Member

tlnagy commented Sep 14, 2018

Just wondering is there a link to some recent discussion about point 5?

This was done mostly offline between me, @bjarthur, and @dcjones, but essentially the idea is that JuliaPlots is expanding to not just be Plots.jl and would give Gadfly.jl more of an official stamp of approval (even though it actually doesn't change anything). New users might be put off by the lack of an official-sounding JuliaX organization.

@tlnagy
Copy link
Member

tlnagy commented Sep 14, 2018

Was point 3 resolved by #1193?

@bjarthur
Copy link
Member Author

yes. thanks @nalimilan !

@montyvesselinov
Copy link

ETA for julia 0.7 release?

@tlnagy
Copy link
Member

tlnagy commented Sep 18, 2018

We'll probably be tagging a new release by the end of the week. You can use Compose and Gadfly master for now.

@montyvesselinov
Copy link

montyvesselinov commented Sep 18, 2018 via email

@tlnagy
Copy link
Member

tlnagy commented Oct 11, 2018

@bjarthur we should go ahead and release Gadfly for Julia 1.0. Can you update the README and then we can pull the trigger. I'm comfortable releasing it now.

@bjarthur
Copy link
Member Author

i should be done with #1204 today. let me merge that before we tag

@tlnagy
Copy link
Member

tlnagy commented Oct 16, 2018

Alright, I'm gonna merge GiovineItalia/Compose.jl#319 soon and then tag a new version of Compose. Then we should go ahead and tag a new version of Gadfly immediately after that. Sound reasonable? Let's have a 1.0 release out in the next 24 hours.

@tlnagy
Copy link
Member

tlnagy commented Oct 18, 2018

@Mattriks
Copy link
Member

The docs don't seem to be rebuilding on latest e.g. new code and figure added in #1201 should appear in Geom.abline: http://gadflyjl.org/latest/gallery/geometries.html.
The docs build for me locally with CSV 0.4.1 etc.

@tlnagy
Copy link
Member

tlnagy commented Oct 19, 2018

Looks like the problem is strip returning a substring now: JuliaLang/julia#22496

ERROR: MethodError: no method matching add_or_develop(::SubString{String}; mode=:add)
Closest candidates are:
  add_or_develop(!Matched::Pkg.Types.Context, !Matched::Array{Pkg.Types.PackageSpec,1}; mode, shared, kwargs...) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:32
  add_or_develop(!Matched::Array{Pkg.Types.PackageSpec,1}; kwargs...) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:29
  add_or_develop(!Matched::Array{String,1}; kwargs...) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:28
  ...
Stacktrace:
 [1] #add#18(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::SubString{String}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:69
 [2] add(::SubString{String}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:69
 [3] (::getfield(Main, Symbol("##3#4")))(::String) at ./none:1
 [4] foreach(::getfield(Main, Symbol("##3#4")), ::Array{String,1}) at ./abstractarray.jl:1835
 [5] top-level scope at none:0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants