Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable alpha for Geom.rect #1439

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented May 17, 2020

  • I've updated the documentation to reflect these changes
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

x1, y1, w1 = 0.5:10, rand(10), 0.09.+0.4*rand(10)
D = DataFrame(x=x1, y=rand(x1, 10), y1=y1, x2=x1.+w1, y2=y1.+w1, c=0:9)
p1 = plot(D, xmin=:x, ymin=:y1, xmax=:x2, ymax=:y2, color=[colorant"green"], alpha=1:10,
    Geom.rect, Scale.alpha_discrete)
p2 = plot(D, xmin=:x, ymin=:y1, xmax=:x2, ymax=:y2, color=:c, alpha=[0.7],
    Geom.rect, Guide.ylabel(nothing))
p3 = plot(D, x=:x, y=:y, color=:c, alpha=[0.5], Geom.rectbin, Scale.color_discrete)
hstack(p1, p2, p3)

geom_rect_alpha

@codecov-io
Copy link

codecov-io commented May 17, 2020

Codecov Report

Merging #1439 into master will decrease coverage by 0.84%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   90.26%   89.42%   -0.85%     
==========================================
  Files          39       39              
  Lines        4140     4369     +229     
==========================================
+ Hits         3737     3907     +170     
- Misses        403      462      +59     
Impacted Files Coverage Δ
src/geom/rectbin.jl 80.00% <66.66%> (-7.50%) ⬇️
src/poetry.jl 90.74% <0.00%> (-5.26%) ⬇️
src/theme.jl 65.07% <0.00%> (-4.42%) ⬇️
src/geom/label.jl 96.26% <0.00%> (-2.74%) ⬇️
src/geom/beeswarm.jl 90.00% <0.00%> (-2.65%) ⬇️
src/aesthetics.jl 77.77% <0.00%> (-2.06%) ⬇️
src/misc.jl 65.06% <0.00%> (-2.06%) ⬇️
src/Gadfly.jl 76.00% <0.00%> (-1.94%) ⬇️
src/color_misc.jl 60.60% <0.00%> (-1.47%) ⬇️
src/guide/keys.jl 81.81% <0.00%> (-1.24%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c708b...e1d6762. Read the comment docs.

@Mattriks Mattriks mentioned this pull request May 17, 2020
@Mattriks Mattriks merged commit 44d9ca8 into GiovineItalia:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpha in SVGJS
2 participants