Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: GiphyGridController cells are inaccessible while using VoiceOver #82

Closed
3arrett opened this issue Jul 30, 2020 · 5 comments

Comments

@3arrett
Copy link

3arrett commented Jul 30, 2020

Using the latest version 1.3.0 and the GiphyGridController embedded.

While using the VoiceOver, neither the Cells nor the UICollectionView is accessible. You can tap a cell and it will read presumably the fileName but gives no focus and you can't scroll the collection view either.

@cgmaier
Copy link
Contributor

cgmaier commented Jul 30, 2020

hey @3arrett, would love to help with this. do you have any pointers on how to achieve this behavior?

is it just a matter of exposing / documenting accessibility labels for the UICollectionView and cells?

@3arrett
Copy link
Author

3arrett commented Jul 30, 2020

Yeah, by default UICollectionViewCells aren't an accessibility element and infer their contents if any. Since the only content in the GPHMediaCell is the ImageView, it why tapping it reads off the file name.

At a minimum you can just add isAccessibilityElement = true on the GPHMediaCell itself. Not knowing the full API, if you have a relevant name for the cell you can add that as the accessibilityLabel itself. Otherwise if you're just ending up being generic, it'd always be good to announce it's position within the datasource, e.g. GIF 3 of 700

There shouldn't be much more than that because once you have cells accessible, you are now able to triple swipe up and down to page through all the elements.

@3arrett
Copy link
Author

3arrett commented Aug 7, 2020

Great! A great resource also to take look into is the WWDC videos. Here are some of the quick overview ones you can take a look into to:

@lizmaddy
Copy link

@cgmaier - Any update on resolving this issue?

djrluna pushed a commit that referenced this issue Apr 21, 2021
@cgmaier
Copy link
Contributor

cgmaier commented Jun 21, 2021

hey everyone, as of v2.1.9 GIPHY iOS SDK supports VoiceOver.

We added accessibility information for our GiphyGridController cells - every cell has descriptive text for VoiceOver to read by one-finger tap, and it’s possible to triple-swipe up and down to page through all the elements with VoiceOver on.

@cgmaier cgmaier closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants