Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readcomiconline.li issue #134

Closed
Frostbrewn opened this issue Aug 17, 2023 · 1 comment
Closed

readcomiconline.li issue #134

Frostbrewn opened this issue Aug 17, 2023 · 1 comment

Comments

@Frostbrewn
Copy link

Describe the bug
Runtime error : Slice bounds out of range [ : -1]
This error happens for certain comic series that uses this blogspot link format of RCOn_w

To Reproduce
-url=https://readcomiconline.li/Comic/The-Amazing-Spider-Man-2018/Issue-1?id=136988#1

Expected behavior
Script functioning properly.

Screenshots
image
Caption : Runtime error : Slice bounds out of range [ : -1]

image
Caption : Suspected due to "RCOn_w" variance in URL parameter

image
Caption : Appears on pages that has this edit

image
Caption : This issue can download as intended

image
Caption : The usual URL that works for this domain

image
Caption : deobfuscateUrl()
Desktop (please complete the following information):

  • OS : Windows 11
  • Version : 22H2
  • Type : CLI

Additional context
Also, I would like to understand in detail about the deobfuscateUrl() function. I hope that you will be willing to impart some knowledge to a beginner like me.

@Girbons
Copy link
Owner

Girbons commented Aug 19, 2023

Hi @Frostbrewn thanks for the report!

This error happens for certain comic series that uses this blogspot link format of RCOn_w

the fix should be pretty easy, we should get the url by replacing _x236 and _x945

Also, I would like to understand in detail about the deobfuscateUrl() function. I hope that you will be willing to impart some knowledge to a beginner like me.

it's just a string manipulation, I took that from readcomiconline

Girbons added a commit that referenced this issue Aug 20, 2023
Girbons added a commit that referenced this issue Aug 20, 2023
@Girbons Girbons closed this as completed Aug 20, 2023
Girbons added a commit that referenced this issue Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants