Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a style to gate layer in count trajectories and add a way to create a valid gate layer #71

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

JuhoErvasti
Copy link
Collaborator

@JuhoErvasti JuhoErvasti commented Nov 5, 2024

Fixes #69
Fixes #70

@JuhoErvasti JuhoErvasti requested a review from msorvoja November 5, 2024 14:13
Copy link
Collaborator

@msorvoja msorvoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuhoErvasti Looks very good! Just one thing: As module fvh3t/core/line_layer.py was not used here, it can/should be removed, right?

@JuhoErvasti
Copy link
Collaborator Author

True, I copied it as qgis_layer_utils.py but forgot to delete the original.

@JuhoErvasti JuhoErvasti force-pushed the 69-add-clearer-style-to-gates branch from 3746a39 to d980dd9 Compare November 6, 2024 06:46
@JuhoErvasti
Copy link
Collaborator Author

@msorvoja Ready for another round

@msorvoja msorvoja merged commit 7770a70 into main Nov 6, 2024
5 checks passed
@msorvoja msorvoja deleted the 69-add-clearer-style-to-gates branch November 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to create a valid gate layer though the GUI Add clearer style to gates
2 participants