-
Notifications
You must be signed in to change notification settings - Fork 154
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(project): add fleshed out contributing.md
- Loading branch information
Showing
3 changed files
with
73 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
## I want to... | ||
|
||
### Submit a bug report | ||
|
||
- Make sure you can reproduce it in the latest version of GitGuardian Shield. | ||
- Open an issue on the [issue tracker](https://github.com/GitGuardian/gg-shield/issues). | ||
|
||
### Fix an open and confirmed bug | ||
|
||
- This bug will have a `confirmed` tag on the issue tracker. | ||
- Leave a message on the issue tracker that you're interested in | ||
fixing this bug. | ||
|
||
### Propose a new feature | ||
|
||
- Open an issue on the [issue tracker](https://github.com/GitGuardian/gg-shield/issues). | ||
|
||
### Implement a new CI integration | ||
|
||
- Open an issue on the [issue tracker](https://github.com/GitGuardian/gg-shield/issues). | ||
- No core contributor review is necessary on this feature. | ||
- Submit a Pull request | ||
|
||
### Implement a new feature | ||
|
||
- Follow `Propose a new feature` | ||
- A core contributor will work out with you if it's the project's vision | ||
and some rudimentary specs | ||
- Submit a Pull request | ||
|
||
## Setup your development environment | ||
|
||
1. Install pipenv (https://github.com/pypa/pipenv#installation) | ||
|
||
1. Install the pre-commit framework (https://pre-commit.com/#install) | ||
|
||
1. Fork and clone the repository | ||
|
||
1. Install dev packages and environment | ||
|
||
```sh | ||
$ pipenv install --dev | ||
``` | ||
|
||
1. Install pre-commit hooks | ||
|
||
```sh | ||
$ pre-commit install | ||
``` | ||
|
||
## Style guides | ||
|
||
### Git commit message | ||
|
||
- Use the present tense ("Add feature" not "Added feature") | ||
- Use the imperative mood ("Move cursor to..." not "Moves cursor to...") | ||
- [Use conventional commit messages](https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-scope), examples: | ||
- feat(integration): Add Azure Pipelines support | ||
- fix(ggshield): add pre-push mode header | ||
|
||
### Python | ||
|
||
- We're committed to support python 3.6+ for now | ||
- Document new functions added if they're not obvious | ||
- Black, flake and isort should keep the rest of your code standard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
## Reporting a vulnerability | ||
|
||
By preference: | ||
|
||
- Send an email to support@gitguardian.com | ||
- Send an email to a core contributor directly | ||
|
||
If you get no response in the next 2 business days, try another avenue of communication, we are very committed to providing quick follow-up on vulnerability reports. |