Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmillet/spi 671 improve ignore reason #1035

Closed
wants to merge 6 commits into from

Conversation

gg-mmill
Copy link
Contributor

Context

What has been done

Validation

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@gg-mmill gg-mmill requested a review from a team as a code owner December 20, 2024 13:18
@gg-mmill gg-mmill closed this Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (6d0d8b8) to head (ac3be17).

Files with missing lines Patch % Lines
...gshield/verticals/secret/secret_scan_collection.py 97.14% 2 Missing ⚠️
ggshield/verticals/secret/extended_match.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         181      181           
  Lines        7726     7755   +29     
=======================================
+ Hits         7112     7139   +27     
- Misses        614      616    +2     
Flag Coverage Δ
unittests 92.05% <97.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant