Fix test failure #520
Merged
Fix test failure #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 93.81% 93.87% +0.05%
==========================================
Files 80 83 +3
Lines 3818 3839 +21
==========================================
+ Hits 3582 3604 +22
+ Misses 236 235 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
agateau-gg
force-pushed
the
agateau/unbreak-tests
branch
7 times, most recently
from
2575101 to
c652798
Compare
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed. Needed a hack in the "Install dependencies" step to work around a build failure on Windows: for some reason the Windows builder still had urllib 2.0.2 installed. Could not reproduce this in my Windows VM so I suspect there is a bug in the way the setup-python GitHub action works.
agateau-gg
force-pushed
the
agateau/unbreak-tests
branch
from
c652798 to
e641df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed.