This repository was archived by the owner on Sep 20, 2023. It is now read-only.
[Settings] [Issue #1927] Added Rate on App Store cell #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings which links to app store rather than in-app rating
BasThomas
reviewed
Jul 19, 2018
| onAccounts() | ||
| } else if cell === githubStatusCell { | ||
| onGitHubStatus() | ||
| }else if cell === reivewOnAppStoreCell { |
Collaborator
There was a problem hiding this comment.
Nit: space before else.
Collaborator
Author
There was a problem hiding this comment.
Got it. @BasThomas Whats Nit stand for?
Collaborator
There was a problem hiding this comment.
It’s defined here as a “minor shortcoming”. In this case that it doesn’t really need fixing, but it would be nice.
| presentSafari(url: url) | ||
| } | ||
|
|
||
| func onReivewOnAppStore() { |
| guard let url = URL(string: "itms-apps://itunes.apple.com/us/app/githawk-for-github/id1252320249") | ||
| else { fatalError("Should always be valid app store URL") } | ||
| if UIApplication.shared.canOpenURL(url) { | ||
| UIApplication.shared.open(url, options: [:], completionHandler: nil) |
Collaborator
There was a problem hiding this comment.
Nit: you can omit the options and completionHandler parameter as they default to [:] and nil respectively.
BrianLitwin
pushed a commit
to BrianLitwin/GitHawk
that referenced
this pull request
Jul 22, 2018
…awkApp#1939) * [Settings] [Issue GitHawkApp#1927] Added Rate on App Store cell in Settings which links to app store rather than in-app rating * Fixed wording and spacing
rizwankce
referenced
this pull request
in rizwankce/GitHawk
Jul 25, 2018
* 'master' of https://github.com/GitHawkApp/GitHawk: (246 commits) [Settings] [Issue #1927] Added Rate on App Store cell (#1939) Add space when replying to issue comment (#1959) Initial ContextMenu cells made accessibility buttons (#1951) README: Update outdated repo URL (#1946) Rewrote the Setup/Getting started page to help contributors get the GitHawk project set up. (#1937) fix selection bug (#1932) add haptics on menu (#1933) add done button to menu VCs (#1934) add insets to issue with new button design (#1935) When there’s no unread messagee, disable mark all as read (#1919) fix crash from management refactor (#1915) New ContextMenu UX for managing Issues & PRs (#1912) Update to latest ContextMenu (#1914) Update MessageViewController (#1913) Update StyledTextKit with layout revert (#1911) Update Squawk (#1910) Updated StyledTextKit (#1909) dims non-actionable subviews in notification cell (#1908) reorders read/watch buttons (#1906) Migrate Toast component to new Squawk CocoaPod library (#1900) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storyboard changes are due to the new cell addition. Y pos of each cell in 2nd section were moved down as the new cell was placed on the very top.