Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Conversation

@telip007
Copy link
Contributor

Added button as accessibilityTrait for the cells in the Context Menu. VoiceOver now reads out for example Labels - Button or Assignees - Button. Fixes #1948

@rnystrom rnystrom merged commit eb19255 into GitHawkApp:master Jul 20, 2018
@telip007 telip007 deleted the feature/accessibility-in-context-menu branch July 20, 2018 15:58
@BasThomas
Copy link
Collaborator

Nice one @telip007!

rizwankce referenced this pull request in rizwankce/GitHawk Jul 25, 2018
* 'master' of https://github.com/GitHawkApp/GitHawk: (246 commits)
  [Settings]  [Issue #1927] Added Rate on App Store cell  (#1939)
  Add space when replying to issue comment (#1959)
  Initial ContextMenu cells made accessibility buttons (#1951)
  README: Update outdated repo URL (#1946)
  Rewrote the Setup/Getting started page to help contributors get the GitHawk project set up. (#1937)
  fix selection bug (#1932)
  add haptics on menu (#1933)
  add done button to menu VCs (#1934)
  add insets to issue with new button design (#1935)
  When there’s no unread messagee, disable mark all as read (#1919)
  fix crash from management refactor (#1915)
  New ContextMenu UX for managing Issues & PRs (#1912)
  Update to latest ContextMenu (#1914)
  Update MessageViewController (#1913)
  Update StyledTextKit with layout revert (#1911)
  Update Squawk (#1910)
  Updated StyledTextKit (#1909)
  dims non-actionable subviews in notification cell (#1908)
  reorders read/watch buttons (#1906)
  Migrate Toast component to new Squawk CocoaPod library (#1900)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants