This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Reactions with ContextMenu #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Love it! Sent with GitHawk |
Member
Author
|
I'll try and sneak this in for the latest release, why not. The whole UIMenu stuff seems to break a lot of things w/ the |
Collaborator
|
Go for it :) |
Member
Author
|
#yolo |
Closed
BasThomas
reviewed
Aug 13, 2018
| else { return } | ||
|
|
||
| var index = -1 | ||
| for (i, model) in viewModels.reversed().enumerated() { |
Collaborator
There was a problem hiding this comment.
Not sure what you're doing here. Can't parse it from the code 😕
Collaborator
There was a problem hiding this comment.
Putting it in a separate function (+ tests) would not be a bad idea I think 😇
| menu.setTargetRect(addButton.imageView?.frame ?? .zero, in: addButton) | ||
| menu.setMenuVisible(true, animated: trueUnlessReduceMotionEnabled) | ||
| @objc private func onAddButton(sender: UIView) { | ||
| // addButton.becomeFirstResponder() |
Collaborator
There was a problem hiding this comment.
This can be removed, or?
Collaborator
|
Didn’t see this. Looks amazing! 🤯 Sent with GitHawk |
Collaborator
|
Was |
Collaborator
|
We should add the Sent with GitHawk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to do some cleanup, but this looks pretty neat