-
Notifications
You must be signed in to change notification settings - Fork 6
Use globally unique filekeys for referencing other yaml files #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use globally unique filekeys for referencing other yaml files #16
Conversation
7b51bb8 to
389d3c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Could you also change the |
389d3c3 to
0e4502c
Compare
|
This is now updated to use "filekeys" for cross-referencing. |
|
Can we drop the |
Co-authored-by: Peter Stöckli <p-@github.com>
585f3c1 to
104a974
Compare
|
smoke test |
The main change is in
yaml_parser.pywhere I've removed the optionalrecurseanddir_namespaceparameters. It now always recurses and always creates a namespaced name. Also, the name is no longer defined by the filename, but instead by the "filekey" that is defined in the yaml, like this:This has the benefit that a yaml file can moved to a different directory without breaking any cross-references. It also means that we can gather yaml files from a variety of sources, dump them all in one directory tree, and easily start using them.