Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

Attempt to fix these errors. I mistakenly thought that environment is a valid type for workflow_call, but it turns out that I saw it in the documentation for workflow_dispatch.

Screenshot from 2025-11-05 10-02-10 Screenshot from 2025-11-05 10-01-03

Copilot AI review requested due to automatic review settings November 5, 2025 10:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the GitHub Actions workflow configuration to properly handle environment declarations in reusable workflows by moving the environment configuration from the caller's job level to the reusable workflow's job level and renaming the input parameter.

  • Moved environment configuration from job level in the caller workflow to the uses workflow input
  • Renamed the reusable workflow input from environment (type: environment) to environment_name (type: string)
  • Updated the caller workflow to pass environment name as a string input instead of passing it as a structured object

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish-to-testpypi.yaml Moved environment configuration from workflow input to job level and updated to pass environment name as string
.github/workflows/publish-reusable.yml Changed input parameter from environment to environment_name with type string instead of environment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JarLob
JarLob previously approved these changes Nov 5, 2025
@kevinbackhouse kevinbackhouse merged commit 1b56b3a into GitHubSecurityLab:main Nov 5, 2025
9 checks passed
@kevinbackhouse kevinbackhouse deleted the environment branch November 5, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants