Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

Trying to fix this error:

Screenshot from 2025-11-05 10-46-45

Copilot AI review requested due to automatic review settings November 5, 2025 10:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to refactor the GitHub Actions workflow for publishing to TestPyPI by moving the environment configuration from the job level to a reusable workflow parameter. The change removes the job-level runs-on and environment configuration and attempts to pass environment details as a JSON string parameter.

  • Removes job-level runs-on and environment configuration from the publish job
  • Attempts to pass environment configuration as a JSON string to the reusable workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

release_notes: ${{ github.head_ref }}
repository_url: https://test.pypi.org/legacy/
environment: testpypi
environment: '{"name": "testpypi", "url": "https://test.pypi.org/p/seclab-taskflow-agent2"}'
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow expects an input parameter named environment_name (not environment), and it should be a simple string value like 'testpypi', not a JSON object. The environment configuration with name and URL should be defined at the job level in this workflow, not passed as a parameter. Change this line to environment_name: testpypi and restore the job-level configuration that was removed.

Suggested change
environment: '{"name": "testpypi", "url": "https://test.pypi.org/p/seclab-taskflow-agent2"}'
environment_name: testpypi
environment:
name: testpypi
url: https://test.pypi.org/p/seclab-taskflow-agent2

Copilot uses AI. Check for mistakes.
environment:
name: testpypi
url: https://test.pypi.org/p/seclab-taskflow-agent2
permissions:
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runs-on key is required for all jobs that don't call reusable workflows with uses. Since this job calls a reusable workflow, the runs-on should not be defined here (it's defined in the reusable workflow). However, the environment configuration that was removed should be restored at this job level, as it cannot be passed as a parameter to control deployment environments properly.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants