Remove reusable workflow because it's not supported by trusted publishing #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
requested review from
JarLob,
m-y-mo,
p- and
sylwia-budzynska
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TestPyPI publishing workflow by inlining the reusable workflow logic directly into the publish-to-testpypi.yaml file and removing the now-unused publish-reusable.yml workflow.
Key changes:
- Removed the reusable workflow file that was previously used for publishing
- Inlined all publish steps directly into the TestPyPI workflow
- Changed from manual version input to auto-generated timestamped test release names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/publish-to-testpypi.yaml | Converted from calling a reusable workflow to containing inline publish steps with auto-generated test release names |
| .github/workflows/publish-reusable.yml | Deleted the reusable workflow file that is no longer needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I got this working in #53, but it turns out that you can't do trusted publishing from a reusable workflow. So unfortunately, there will be some code duplication when I add the
publish-to-pypi.yamlworkflow.