-
Notifications
You must be signed in to change notification settings - Fork 7
Run the code from the PR, not from main #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the code from the PR, not from main #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the smoketest workflow to better handle PR comments by adding explicit PR validation and changing the checkout mechanism from the standard GitHub Actions checkout action to using the GitHub CLI.
- Added a conditional check to ensure the workflow only runs when comments are on pull requests
- Replaced the
actions/checkout@v5action with agh pr checkoutcommand using the PR number from the event context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c248441 to
1842ad2
Compare
|
@JarLob: what do you think about the CodeQL alert? I think this code is safe because we're using the branch-deploy action. |
|
Yes, this is because there is no exception for the branch deploy action in the rule. |
The smoke test isn't working properly, because it's checking out the code from main, rather than the pull request. I've added a step that uses the GitHub CLI to checkout the pull request.