Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

@kevinbackhouse kevinbackhouse commented Nov 7, 2025

The smoke test isn't working properly, because it's checking out the code from main, rather than the pull request. I've added a step that uses the GitHub CLI to checkout the pull request.

Copilot AI review requested due to automatic review settings November 7, 2025 16:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the smoketest workflow to better handle PR comments by adding explicit PR validation and changing the checkout mechanism from the standard GitHub Actions checkout action to using the GitHub CLI.

  • Added a conditional check to ensure the workflow only runs when comments are on pull requests
  • Replaced the actions/checkout@v5 action with a gh pr checkout command using the PR number from the event context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 7, 2025 16:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse
Copy link
Collaborator Author

@JarLob: what do you think about the CodeQL alert? I think this code is safe because we're using the branch-deploy action.

@JarLob
Copy link
Contributor

JarLob commented Nov 7, 2025

Yes, this is because there is no exception for the branch deploy action in the rule.

@kevinbackhouse kevinbackhouse merged commit 456e309 into GitHubSecurityLab:main Nov 7, 2025
9 checks passed
@kevinbackhouse kevinbackhouse deleted the smoketest branch November 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants