Skip to content

Conversation

@Seretos
Copy link
Contributor

@Seretos Seretos commented Jan 14, 2017

Hihi, thanks for this api...

i have added a little method to get the artifacts zip file from a single build

@m4tthumphrey
Copy link
Contributor

Can you remove the .idea from the gitignore please and fix the CS on the line I've commented on above. Hint: Add .idea to your global ignore file.

$api->expects($this->once())
->method('get')
->with('projects/1/builds/2/artifacts')
->will($this->returnValue($expectedArray))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between comma and 2

.gitignore Outdated
vendor/
composer.lock
.idea/
composer.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@moufmouf
Copy link
Contributor

@Seretos I think @m4tthumphrey is waiting for you to remove the addition of "composer.lock" in the .gitignore file before merging. Would you mind removing this? (I badly need this to be merged for one of my libs :) )

Thanks by the way to both of you for your great work!

@radutopala
Copy link
Contributor

@Seretos can't seem to find the API endpoints for /projects/:id/builds/:id/* .. were those moved to https://docs.gitlab.com/ce/api/ci/builds.html?

@moufmouf
Copy link
Contributor

@radutopala You don't want to use the Builds API you are referring to (https://docs.gitlab.com/ce/api/ci/builds.html). This is reserved to be used only by the runners.

You really want to use the Jobs API: https://docs.gitlab.com/ce/api/jobs.html#download-the-artifacts-file

By the way, I tested this PR in both Gitlab 8 and Gitlab 9 and it works.

@moufmouf moufmouf mentioned this pull request Jun 19, 2017
@fbourigault
Copy link
Contributor

I'm closing this PR as it use runners reserved API and it's superseded by #196. Thank you anyway!

@fbourigault fbourigault closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants