added DocumentSnapshot.dataMap() (fixes #186) #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reedyuk
reviewed
Sep 1, 2021
firebase-firestore/src/androidMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt
Outdated
Show resolved
Hide resolved
Reedyuk
reviewed
Sep 1, 2021
firebase-firestore/src/iosMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt
Outdated
Show resolved
Hide resolved
Reedyuk
approved these changes
Sep 1, 2021
|
This one slipped past me but I believe dataMap() is flawed due to the reason stated here #38 (comment) and should probably be removed to avoid exposing platform specific types to the multiplaform code. Forcing usage of kotlinx-serialization is the only way to ensure the api remains platform dependent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.