Api Validation, Explicit API Mode & Linting #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next step will be to remove the internal classes from the API, I think its just the Native... classes found in these two modules: https://github.com/GitLiveApp/firebase-kotlin-sdk/blob/b72a3cf86debf4e26b95cb9b2e9ac664157a0036/firebase-firestore/api/android/firebase-firestore.api |
|
As in, you want me to do that in this pr? For reviewability I'd recommend doing it in a separate pr |
|
Agreed |
nbransby
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535 #534 and adds lint. Also did some cleanup based on code inspection
By its very nature this is a large PR with many code changes. However, no functional changes where made in the code. I recommend reviewing the gradle & workflow scripts and just scanning the actual code
Also, because I know its controversial: I left lint to use the standard Intellij rules. This means that trailing commas have been added. I've not disabled any rules except for wildcard imports / import ordering since those tend to conflict with the IDE in my experience