Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Crash when changing to a tab where the terminal has been previously opened and then closed #873

Closed
3 of 10 tasks
Blue3agle opened this issue Nov 9, 2020 · 1 comment
Closed
3 of 10 tasks

Comments

@Blue3agle
Copy link

Technical information

Using version:

  • master (running from GitHub-published source code, currently v3.0.0-pre)
  • latest (latest release, currently v2.2.2)
  • vX.X.X (specify other version)

Running on:

  • Linux
  • Windows (Powershell in terminal)
  • macOS

How comfortable you are with your system and/or IT in general:

  • I'm kind of lost, honestly
  • I know what's up, I could help you run some commands or checks
  • My machine is fully under my control, tell me what you need
  • I attended Defcon last year

Problem

Short description: Opening a terminal, then exiting it and re-opening it crashes eDEX-UI with error "eDEX-UI crashed" "Cannot resize a pty tha has already exited"

Reproduction:
Start eDEX-UI
Press CTRL+2 to open terminal 2
Type 'exit' to terminate powershell and return to the main shell
Press CTRL+2 to open terminal 2
Crash

My guess is that eDEX-UI doesn't un-flag a terminal as being open when it is closed. It appears to register that a terminal is closed because the tab title goes from "#2 -" to "EMPTY". Also before it crashes the title of the tab is changed to "::3002". When it then attempts to re-open the tab it thinks that there is a tty there, when there is not. In any case it is important to assert that there is a tty linked to the terminal before attempting to resize it, and if there is not a new terminal has to be attached to the tab.

Thank you for a very fun product.

@Animus-Surge
Copy link
Contributor

Animus-Surge commented Nov 9, 2020

Can confirm that this is happening. Happens in master and v2.2.2. Doesn't happen with just powershell either, also happens with cmd. I tested on raspbian and the issue didn't occour, so I'm thinking that this might be Windows specific.

edited for understanding

@lebarde lebarde mentioned this issue Nov 25, 2020
18 tasks
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this issue Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants