Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Added theme without keyboard #288

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Added theme without keyboard #288

merged 1 commit into from
Nov 25, 2018

Conversation

WR4F
Copy link
Contributor

@WR4F WR4F commented Nov 25, 2018

Solves the problem behind issue #259

There is now a theme named tron-notype that has no keyboard and also has a larger filesystem pane. Change it to your default theme by editing userData/settings.json and changing "theme":"tron" to "theme":"tron-notype".

@Escalion
Copy link

It would be nicer if the _renderer.js function to initialise the UI could be passed an option so that the keyboard isn't rendered into the DOM at all.

It would be a serious rewrite and would require layout arguments to be defined in a configuration file so that the user can fully define each component available on the display.

@GitSquared
Copy link
Owner

@Escalion the overrall architecture of eDEX was made with the possibility of customising components in mind. However this feature won't be implemented soon because

  1. there aren't any "extra" components to choose from yet

  2. i need to fully rewrite components and their architecture to make separate threads for rendering and collecting information

Also right now the keyboard, the filesystem display and the terminal are deeply linked to each other and don't follow the same principles as other modules like the clock or the globe. I might consider the possibility of customising them one day, but that's even further away.

In the meantime this PR is a good workaround and keeping the keyboard working even though it's invisible shouldn't harm the CPU too much. Merging.

@GitSquared GitSquared merged commit 790fe97 into GitSquared:master Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants