Fix #737

[N1KN1M]

Closes #737

Previously, all icons were in a single row, which became bothersome when scaling.

[razaamir]

Grid system for what? More detail please

On Sat, Nov 7, 2020 at 4:33 PM N1KN1M ***@***.***> wrote: As per #737 <http://url>. Previously, all icons were in a single row, which became bothersome when scaling. ------------------------------ You can view, comment on, or merge this pull request online at: #857 Commit Summary - Changed disk layout to use inherited grid layout, added some padding for spacing from border. File Changes - *M* src/assets/css/filesystem.css <https://github.com/GitSquared/edex-ui/pull/857/files#diff-5edea9ff7580da9667b8453e5fa577a2ccd82cc5f4e57c2ee4076d39e288548b> (2) Patch Links: - https://github.com/GitSquared/edex-ui/pull/857.patch - https://github.com/GitSquared/edex-ui/pull/857.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#857>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGK5TGB474YDJHI2PQDETLSOUWCDANCNFSM4TNTENBA> .

-- Raza Amir

[N1KN1M]

@GitSquared I tried adding you as a reviewer / assigning it to you but it seems like PR authors don't have such permissions in github.

[razaamir]

I was one of the prime founders of Github

On Sat, Nov 7, 2020 at 4:52 PM N1KN1M ***@***.***> wrote: @GitSquared <https://github.com/GitSquared> I tried adding you as a reviewer / assigning it to you but it seems like we don't have such permissions in github — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGK5TGPFEFZV4XS2AWL753SOUYJFANCNFSM4TNTENBA> .

-- Raza Amir

[GitSquared]

@GitSquared I tried adding you as a reviewer / assigning it to you but it seems like PR authors don't have such permissions in github.

No need, i'm notified either way. Will review this ASAP, thanks!

[GitSquared]

(nvm, see review below)

[razaamir]

Using iOS, none of this makes sense to me Raza

On Sat, Nov 7, 2020 at 9:16 PM Gaby ***@***.***> wrote: For some reason this doesn't work for me... [image: Screenshot_20201107_171404] <https://user-images.githubusercontent.com/24496417/98446280-b5554f80-211c-11eb-9834-5bdbe21af066.png> I've tried enabling back flexbox and adding a flex-wrap and it seems to work: [image: Screenshot_20201107_171421] <https://user-images.githubusercontent.com/24496417/98446301-e2a1fd80-211c-11eb-8845-fefc1250a407.png> How does it work on your end? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGK5TB7Q5M5I5GUCUHUS2TSOVXHDANCNFSM4TNTENBA> .

-- Raza Amir

[GitSquared]

Check line :109 of the same file, when list view (Ctrl+Shift+L) is enabled this will break.

Perhaps using flex-wrap instead of deactivating flexbox would be easier, and might also retain the center alignment of the disk view items? 🤔

[N1KN1M]

Ah, sorry about that; wasn't aware of list view 😅
Actually, simply adding in flex-wrap brings the list view for disks to be pretty much the same as the normal grid view (the only slight difference being spacing between border and items due to different grid-gap attributes).
Here's what both views look like on my screen(with flex-wrap):

Grid View:

List View:

Is that alright or is it preferred to have horizontal scrolling on the original disk view instead?

[GitSquared]

Yeah, it's good! Can you scroll down if there are multiple screens of disks though? Just want to make sure

[N1KN1M]

Yep, I'm able to scroll after copy pasting a couple of divs in dev tools.

[GitSquared]

All good, thanks for taking the time to work on this!

[N1KN1M]

Thanks Gaby, glad I can be of help!

[razaamir]

Here you go, some music for you https://soundcloud.app.goo.gl/79K35xmWzK8yQjzy6

On Sun, Nov 8, 2020 at 2:57 AM Nikhil ***@***.***> wrote: Thanks Gaby, glad I can be of help! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGK5TETJGCLJ2MEE3NWL7LSOW7FJANCNFSM4TNTENBA> .

-- Raza Amir