Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Fix issue where images wouldn't load from general filesystem on Windows #862

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Conversation

Animus-Surge
Copy link
Contributor

I found an issue while poking about the master branch on Windows where if you click an image in the filesystem, the image wouldn't load. It came up with an error in the dev console that looked something like this:

/C:/%5CUsers%5CSurge%5CDesktop%5Cwofrpg-site-NEW%5Cmain%5Cimages%5Cicon.png:1 GET file:///C:/%5CUsers%5CSurge%5CDesktop%5Cwofrpg-site-NEW%5Cmain%5Cimages%5Cicon.png net::ERR_FAILED
Image (async)
Modal @ modal.class.js:90
FilesystemDisplay.openMedia @ filesystem.class.js:570
onclick @ ui.html:1

I fixed the issue by adding a line in the openMedia function of the filesystem class that replaces all backslashes with forward slashes. It could definitely be done a lot better, but this does work without any issues.

@GitSquared
Copy link
Owner

Thanks!

@GitSquared GitSquared merged commit 7ac1b3c into GitSquared:master Nov 8, 2020
@lebarde lebarde mentioned this pull request Nov 25, 2020
18 tasks
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this pull request Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants