Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly taking case into consideration when inspecting labels #374

Closed
gep13 opened this issue Apr 26, 2021 · 1 comment
Closed

Incorrectly taking case into consideration when inspecting labels #374

gep13 opened this issue Apr 26, 2021 · 1 comment
Assignees
@gep13
Labels
Build
Milestone
0.12.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 26, 2021

GitRelaeseManager should be case insensitive when it comes to inspecting labels on issues, but this has been regressed.

As discussed on stream 26th April 2021
@gep13 gep13 added the Build label Apr 26, 2021
@gep13 gep13 added this to the 0.12.0 milestone Apr 26, 2021
@gep13 gep13 self-assigned this Apr 26, 2021
gep13 added a commit to gep13/GitReleaseManager that referenced this issue May 10, 2021
@gep13
(GitTools#374) Remove case sensitive search
d8473c1 
GRM is intended to _NOT_ be case sensitive when looking for labels to
add to a release, however, there was a regression where case sensitivity
was added back in. This was found during testing, and reverted.
@gep13 gep13 closed this as completed May 31, 2021
gep13 added a commit that referenced this issue May 31, 2021
@gep13
Merge branch 'release/0.12.0'
7a29d7e 
* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
bb0bb10 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
@gittools-bot
Copy link

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
007cc69 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
gep13 added a commit that referenced this issue May 31, 2021
@gep13
Merge branch 'release/0.12.0' into develop
c637bce 
* release/0.12.0:
  (build) Fix unit tests
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: c637bce
a1c8531 
Merge branch 'release/0.12.0' into develop

* release/0.12.0:
  (build) Fix unit tests
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Build
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@gep13 @gittools-bot