GitVersionTask 5.1.1: object reference not set to an instance of object.

[jetersen]

Fails with 5.1.1, downgrading to 5.0.1 works.

GitVersionTask.targets(56,9): error : Object reference not set to an instance of an object.

When building this csproj

<Project Sdk="Microsoft.Build.NoTargets/1.0.85">

  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <IncludeBuildOutput>false</IncludeBuildOutput>
    <UpdateAssemblyInfo>false</UpdateAssemblyInfo>
    <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
  </PropertyGroup>

  <PropertyGroup>
    <developmentDependency>true</developmentDependency>
    <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
  </PropertyGroup>

  <ItemGroup>
    <Content Include="build\*">
      <PackagePath>build\</PackagePath>
    </Content>
    <Content Include="buildMultiTargeting\*">
      <PackagePath>buildMultiTargeting\</PackagePath>
    </Content>
    <Content Include="tools\**">
      <PackagePath>tools\</PackagePath>
    </Content>
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="GitVersionTask" Version="5.1.1">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
  </ItemGroup>

</Project>

[Bit-Chaos]

I do get the same when using GitVersionTask from within a .NET core 3 container(debian based). The log shows:

/home/vscode/.nuget/packages/gitversiontask/5.1.1/build/GitVersionTask.targets(16,9): Error: Object reference not set to an instance of an object
Project gets loaded from VSCode and the Omnisharp-plugin fails to load the project because of GitVersionTask.
Using version 5.0.1 I do get the following stack-trace:
[warn]: OmniSharp.MSBuild.ProjectLoader
        WARN [10/31/19 7:21:51:99] Could not determine assembly version: System.BadImageFormatException: Method has no body
File name: 'LibGit2Sharp'
  at LibGit2Sharp.Core.Proxy.git_buf_dispose (LibGit2Sharp.Core.Handles.GitBuf buf) [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Handles.GitBuf.Dispose () [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.ConvertPath (System.Func`2[T,TResult] pathRetriever) [0x0002e] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.git_repository_discover (LibGit2Sharp.Core.FilePath start_path) [0x00005] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Repository.Discover (System.String startingPath) [0x00006] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at GitVersion.GitPreparer.GetDotGitDirectory () [0x0000f] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.ExecuteGitVersion (System.String targetUrl, System.String dynamicRepositoryLocation, GitVersion.Authentication authentication, System.String targetBranch, System.Boolean noFetch, System.String workingDirectory, System.String commitId, GitVersion.Config overrideConfig, System.Boolean noCache) [0x00054] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.TryGetVersion (System.String directory, GitVersion.VersionVariables& versionVariables, System.Boolean noFetch, GitVersion.Authentication authentication) [0x00000] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
[warn]: OmniSharp.MSBuild.ProjectLoader
        WARN [10/31/19 7:21:52:02] Could not determine assembly version: System.BadImageFormatException: Method has no body
File name: 'LibGit2Sharp'
  at LibGit2Sharp.Core.Proxy.git_buf_dispose (LibGit2Sharp.Core.Handles.GitBuf buf) [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Handles.GitBuf.Dispose () [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.ConvertPath (System.Func`2[T,TResult] pathRetriever) [0x0002e] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.git_repository_discover (LibGit2Sharp.Core.FilePath start_path) [0x00005] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Repository.Discover (System.String startingPath) [0x00006] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at GitVersion.GitPreparer.GetDotGitDirectory () [0x0000f] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.ExecuteGitVersion (System.String targetUrl, System.String dynamicRepositoryLocation, GitVersion.Authentication authentication, System.String targetBranch, System.Boolean noFetch, System.String workingDirectory, System.String commitId, GitVersion.Config overrideConfig, System.Boolean noCache) [0x00054] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.TryGetVersion (System.String directory, GitVersion.VersionVariables& versionVariables, System.Boolean noFetch, GitVersion.Authentication authentication) [0x00000] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 

Same project outside the container just works fine (i.e. native on Windows 10).
After a bit of investigation it seems that this is a result native-libraries not having all the required dependencies installed. The used docker-image uses debian-10, but the GitVersionTask only provides debian.9. So I assume, that it falls back to linux-64, which then has unresolved dependencies

[patrickklaeren]

I can confirm that 5.1.1 MSBuild task does not work and throws an NRE whenever I attempt to use it on AzDO Pipelines.

Downgrading to 5.0.1 works.

[asbjornu]

@Bit-Chaos, your log contains the warning Could not determine assembly version: System.BadImageFormatException: Method has no body, which seems to be different from @Casz's problem which is a NullReferenceException?

In order to fix any of these problems, it would greatly help if you could help produce a stack trace from a debug build of GitVersion so we could get all frames including line numbers.

[arturcic]

I do get the same when using GitVersionTask from within a .NET core 3 container(debian based). The log shows:

/home/vscode/.nuget/packages/gitversiontask/5.1.1/build/GitVersionTask.targets(16,9): Error: Object reference not set to an instance of an object
Project gets loaded from VSCode and the Omnisharp-plugin fails to load the project because of GitVersionTask.
Using version 5.0.1 I do get the following stack-trace:
[warn]: OmniSharp.MSBuild.ProjectLoader
        WARN [10/31/19 7:21:51:99] Could not determine assembly version: System.BadImageFormatException: Method has no body
File name: 'LibGit2Sharp'
  at LibGit2Sharp.Core.Proxy.git_buf_dispose (LibGit2Sharp.Core.Handles.GitBuf buf) [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Handles.GitBuf.Dispose () [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.ConvertPath (System.Func`2[T,TResult] pathRetriever) [0x0002e] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.git_repository_discover (LibGit2Sharp.Core.FilePath start_path) [0x00005] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Repository.Discover (System.String startingPath) [0x00006] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at GitVersion.GitPreparer.GetDotGitDirectory () [0x0000f] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.ExecuteGitVersion (System.String targetUrl, System.String dynamicRepositoryLocation, GitVersion.Authentication authentication, System.String targetBranch, System.Boolean noFetch, System.String workingDirectory, System.String commitId, GitVersion.Config overrideConfig, System.Boolean noCache) [0x00054] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.TryGetVersion (System.String directory, GitVersion.VersionVariables& versionVariables, System.Boolean noFetch, GitVersion.Authentication authentication) [0x00000] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
[warn]: OmniSharp.MSBuild.ProjectLoader
        WARN [10/31/19 7:21:52:02] Could not determine assembly version: System.BadImageFormatException: Method has no body
File name: 'LibGit2Sharp'
  at LibGit2Sharp.Core.Proxy.git_buf_dispose (LibGit2Sharp.Core.Handles.GitBuf buf) [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Handles.GitBuf.Dispose () [0x00000] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.ConvertPath (System.Func`2[T,TResult] pathRetriever) [0x0002e] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Core.Proxy.git_repository_discover (LibGit2Sharp.Core.FilePath start_path) [0x00005] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at LibGit2Sharp.Repository.Discover (System.String startingPath) [0x00006] in <5e2d125af12e4bcc982f89d05fe51418>:0 
  at GitVersion.GitPreparer.GetDotGitDirectory () [0x0000f] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.ExecuteGitVersion (System.String targetUrl, System.String dynamicRepositoryLocation, GitVersion.Authentication authentication, System.String targetBranch, System.Boolean noFetch, System.String workingDirectory, System.String commitId, GitVersion.Config overrideConfig, System.Boolean noCache) [0x00054] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 
  at GitVersion.ExecuteCore.TryGetVersion (System.String directory, GitVersion.VersionVariables& versionVariables, System.Boolean noFetch, GitVersion.Authentication authentication) [0x00000] in <5ef86c5c4a534bc2b5e01192000f40c0>:0 

Same project outside the container just works fine (i.e. native on Windows 10).
After a bit of investigation it seems that this is a result native-libraries not having all the required dependencies installed. The used docker-image uses debian-10, but the GitVersionTask only provides debian.9. So I assume, that it falls back to linux-64, which then has unresolved dependencies

Currently we do not support debian 10 as the Libgi2sharp.native libraries which we rely on, do not support it yet. So you could use the debian 9 docker image. I will try to find a way to build ourselves the dependencies

[patrickklaeren]

@asbjornu How could I produce logs from Pipelines? We're using the MSBuild task and the only error I get is Object reference not set to an instance of an object with no other indicator as to what it wrong. The exact same repo and config works when downgrading from 5.1.1 to 5.0.1

[Bit-Chaos]

@arturcic When I do use the bionic-image of .NET 3 (mcr.microsoft.com/dotnet/core/sdk:3.0-bionic = Ubuntu 18.04 LTS) instead of the default one (FROM mcr.microsoft.com/dotnet/core/sdk:3.0=debian 10), then the error "Object reference not set to an instance of an object" disappears, but then I do get a new error:
/home/vscode/.nuget/packages/gitversiontask/5.1.1/build/GitVersionTask.targets(16,9): Error: Encoding 37 data could not be found. Make sure you have correct international codeset assembly installed and enabled.

One can easily recreate the problem by creating a container-based C# project, adding GitVersionTask as a reference and then trying to (re-)load the project in OmniSharp. Strangely enough the command-line tools do work, i.e. dotnet restore/build/etc. So it seems to be a combination of GitVersionTask and Omnisharp inside a docker-container. Using the combination natively on the host works without problems.

[arturcic]

@Bit-Chaos , could you create a github repo with a sample of how to reproduce it and the steps, so that we can check it?

[Bit-Chaos]

@arturcic , I just uploaded a test-project to: "https://github.com/Bit-Chaos/GitVersionTask". Once you open the project inside a container using VSCode, you'll get the error when the project is loaded for inspection from Omnisharp. You can recreate the error message every time you try to reload the project (i.e. Ctrl-Shift-P -> "Omnisharp: select project". This project uses the default 3.0 container with debian 10, if you also need a container using Ubuntu, then you'll just have to change the line
FROM mcr.microsoft.com/dotnet/core/sdk:3.0
into
FROM mcr.microsoft.com/dotnet/core/sdk:3.0-bionic
This will result in a different error. So probably it has something to do with the libgit2sharp library (but that's just guessing from my side)

[arturcic]

@Bit-Chaos I have tried the test project you've created and I got the Object reference not set to an instance of an object error. I have also tried the bionic image as you suggested, but it worked perfectly, no errors on my side. So the first error is because of the debian 10 image, that we currently do not support. Using bionic image works.

Starting OmniSharp server at 11/3/2019, 6:27:33 PM
    Target: /workspaces/GitVersionTask

OmniSharp server started.
    Path: /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/run
    PID: 503

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on ubuntu 18.4 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 16.0 - "/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 16.0 - "/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
            MSBuildExtensionsPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild
            BypassFrameworkInstallChecks = true
            CscToolPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/Roslyn
            CscToolExe = csc.exe
            MSBuildToolsPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/workspaces/GitVersionTask'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in '/workspaces/GitVersionTask'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/GitVersionTask/aspnetapp.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/workspaces/GitVersionTask'.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/GitVersionTask/aspnetapp.csproj
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.EditorConfigWorkspaceOptionsProvider, Order: 200
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/workspaces/GitVersionTask' on host 313.
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/GitVersionTask/aspnetapp.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project '/workspaces/GitVersionTask/aspnetapp.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: aspnetapp

[Bit-Chaos]

@arturcic , Hi Artur
when I do load the project with the bionic-image (FROM mcr.microsoft.com/dotnet/core/sdk:3.0-bionic) I do get the following message:

`
Starting OmniSharp server at 11/3/2019, 7:02:21 PM
Target: /workspaces/GitVersionTask

OmniSharp server started.
Path: /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/run
PID: 891

Starting OmniSharp on ubuntu 18.4 (x64)
info: OmniSharp.Services.DotNetCliService
DotNetPath set to dotnet
info: OmniSharp.MSBuild.Discovery.MSBuildLocator
Located 1 MSBuild instance(s)
1: StandAlone 16.0 - "/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
info: OmniSharp.MSBuild.Discovery.MSBuildLocator
MSBUILD_EXE_PATH environment variable set to '/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
info: OmniSharp.MSBuild.Discovery.MSBuildLocator
Registered MSBuild instance: StandAlone 16.0 - "/home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
MSBuildExtensionsPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild
BypassFrameworkInstallChecks = true
CscToolPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/Roslyn
CscToolExe = csc.exe
MSBuildToolsPath = /home/vscode/.vscode-server/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin
info: OmniSharp.Cake.CakeProjectSystem
Detecting Cake files in '/workspaces/GitVersionTask'.
info: OmniSharp.Cake.CakeProjectSystem
Could not find any Cake files
info: OmniSharp.MSBuild.ProjectSystem
No solution files found in '/workspaces/GitVersionTask'
info: OmniSharp.MSBuild.ProjectManager
Queue project update for '/workspaces/GitVersionTask/aspnetapp.csproj'
info: OmniSharp.Script.ScriptProjectSystem
Detecting CSX files in '/workspaces/GitVersionTask'.
info: OmniSharp.Script.ScriptProjectSystem
Could not find any CSX files
info: OmniSharp.WorkspaceInitializer
Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
info: OmniSharp.MSBuild.ProjectManager
Loading project: /workspaces/GitVersionTask/aspnetapp.csproj
info: OmniSharp.WorkspaceInitializer
Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
info: OmniSharp.WorkspaceInitializer
Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.EditorConfigWorkspaceOptionsProvider, Order: 200
info: OmniSharp.WorkspaceInitializer
Configuration finished.
info: OmniSharp.Stdio.Host
Omnisharp server running using Stdio at location '/workspaces/GitVersionTask' on host 212.
fail: OmniSharp.MSBuild.ProjectLoader
Encoding 37 data could not be found. Make sure you have correct international codeset assembly installed and enabled.
[warn]: OmniSharp.MSBuild.ProjectManager
Failed to load project file '/workspaces/GitVersionTask/aspnetapp.csproj'.
/workspaces/GitVersionTask/aspnetapp.csproj
/home/vscode/.nuget/packages/gitversiontask/5.1.1/build/GitVersionTask.targets(16,9): Error: Encoding 37 data could not be found. Make sure you have correct international codeset assembly installed and enabled.

Attempted to update project that is not loaded: /workspaces/GitVersionTask/aspnetapp.csproj
info: OmniSharp.OmniSharpWorkspace
Miscellaneous file: /workspaces/GitVersionTask/obj/Debug/netcoreapp3.0/AssemblyInfo_aspnetapp_bgjp8d6f.mzi.g.cs added to workspace
`
So the error changes from "object refernce" to "/home/vscode/.nuget/packages/gitversiontask/5.1.1/build/GitVersionTask.targets(16,9): Error: Encoding 37 data could not be found. Make sure you have correct international codeset assembly installed and enabled.".

[arturcic]

It seems you don't have a specific encoding installed, I guess in the docker container? or it's on the host?

[Bit-Chaos]

This is all inside the docker container. Just using vanilla image from Microsoft...

[arturcic]

I also use the exact same image, and it works for me. That means the issue is on the host somehow, not on the container.

[Bit-Chaos]

That would be be strange, since the container is supposed to be identical wherever it runs. What kind of host environment are you using?