[Bug] #2167 breaks building WPF applications

[batzen]

Describe the bug
The fixes made for #2167 seem to break building WPF applications because version attributes are added as duplicates.

Expected Behavior

Build should work and assembly info should not have duplicate attributes.

Actual Behavior

Assemblyinfo has duplicate version attributes.

Possible Fix

MarkupCompilePass1DependsOn should not be modified to contain UpdateAssemblyInfo.

Steps to Reproduce

• Clone https://github.com/snoopwpf/snoopwpf
• Compile

Context

Tried to compile with the latest gitversiontask version.
Version 5.2.2 works fine. Only 5.2.3 shows this issue.

Your Environment

.NET Core SDK (reflecting any global.json):
Version: 3.1.101
Commit: b377529961

Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\3.1.101\

Host (useful for support):
Version: 3.1.2
Commit: 916b5cba26

• Version Used: 5.2.3
• Operating System and version (Windows 10): 1909
• Link to your project: https://github.com/snoopwpf/snoopwpf
• Link to your CI build (if appropriate):

[arturcic]

@tpaxatb can you check this bug?

[tpaxatb]

Yeah I realized after the fact that netcore apps seem to build slightly different (i didn't have netcore 3 sdk until friday). I think maybe on the .net core that the UpdateAssemblyInfo should be turned off in the props file or something. I'll see about taking a look later if/when I get a chance, as our office is in the process of transforming to mandatory work at home due to government directives yesterday and today.

[arturcic]

Sure, take your time, any help is welcomed

[bording]

Looks like the PR I just opened should fix this: #2183

[arturcic]

@bording, ok then, after we merge your PR we will validate it here

[arturcic]

closing, please reopen if still reproduces