-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] DisableGitVersionTask ineffective #2640
Comments
Quite possible I'm misunderstanding the dependency chain but shouldn't the "GetVersion" target in GitVersion.MsBuild.targets have a condition attached? Ie
should probably be
Side note - would be happy to try a PR but I can't even run the tests after checking out the repo... |
DisableGitVersionTask is ineffective when running plain build via MSBuild or VS as well. |
@Leszek-Kowalski good point - have renamed the issue to make this more obvious! |
…ersionTask-ineffective Fixing #2640 DisableGitVersionTask ineffective
Hi, |
I just spent the last 6 hours beating my head against what seems like this issue, can I bribe the gitversion team to release this or something? I'd really like to use all this goodness. |
🎉 This issue has been resolved in version 5.6.9 🎉 Your GitReleaseManager bot 📦🚀 |
Describe the bug
The DisableGitVersionTask property was used on the old GitVersionTask package to allow continuous test runners such as Ncrunch to operate without access to the git repository. It appears that no longer works with the new GitVersion.MsBuild package. Instead, gitversion.exe is run and then fails (due to not being able to find '.git').
Expected Behavior
No gitversion tasks should be run if DisableGitVersionTask is set to true
Actual Behavior
Errors such as this occur (from NCrunch Trace Output)
This post describes the same issue (from another user).
Possible Fix
Presumably something in the twisty maze of conditional properties in GitVersion.MsBuild.props is going awry.
Steps to Reproduce
Context
Show stopper since unable to run tests
Your Environment
The text was updated successfully, but these errors were encountered: