Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 6.0 Beta 4 gitversion.msbuild with dotnet build #3832

Closed
christophwille opened this issue Dec 13, 2023 · 9 comments · Fixed by #3835
Closed

[Bug] 6.0 Beta 4 gitversion.msbuild with dotnet build #3832

christophwille opened this issue Dec 13, 2023 · 9 comments · Fixed by #3835
Labels
Milestone

Comments

@christophwille
Copy link

When I add 6.0-b4 msbuild nuget, it works fine in VS. When executing dotnet build on the command line it fails when executing

dotnet --roll-forward Major "C:\Users\chwille\.nuget\packages\gitversion.msbuild\6.0.0-beta.4\tools\/gitversion.dll" "C:\Workspace\src\myProject" -output file -outputfile obj\gitversion.json

(exit code 1)

When I run this separately (in the same directory as dotnet build) I get

Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET program, but dotnet---roll-forward does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.
@arturcic
Copy link
Member

Can you run in a cmd this piece directly?
dotnet --roll-forward Major "C:\Users\chwille\.nuget\packages\gitversion.msbuild\6.0.0-beta.4\tools\/gitversion.dll" "C:\Workspace\src\myProject" -output file -outputfile obj\gitversion.json

@christophwille
Copy link
Author

christophwille commented Dec 13, 2023

As I pointed out I did.

Edit: ah, there are subfolders in C:\Users\chwille.nuget\packages\gitversion.msbuild\6.0.0-beta.4\tools\ - if I add net8.0 eg to the path it works. So seems not to pick entire path.

@christophwille christophwille changed the title [Bug] 6.0 Beta 4 [Bug] 6.0 Beta 4 gitversion.msbuild with dotnet build Dec 13, 2023
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 13, 2023
@arturcic arturcic added this to the 6.x milestone Dec 13, 2023
arturcic added a commit that referenced this issue Dec 13, 2023
#3832 - fix setting the TargetFramework in the GitVersion.MsBuild.targets
@christophwille
Copy link
Author

@arturcic is it possible to get a new beta package on nuget.org?

@arturcic
Copy link
Member

arturcic commented Jan 8, 2024

@christophwille at this moment I cannot give an estimation when we get this released.

There is PR that needs to be reviewed, and as far as I understand there will be a couple more related to the trunk based implementation.

Let me check with @HHobeck if we can have a beta5 before he finishes his work.

@HHobeck
Copy link
Contributor

HHobeck commented Jan 8, 2024

Until now there is only one PR merged to master from me which includes only preparation changes for the actual refactoring task. It is up to you:

  • review the changes and go forward
  • create a package for one bugfix ;)

@arturcic
Copy link
Member

arturcic commented Jan 8, 2024

@HHobeck, I think we can go with the beta5 and then your changes will get into beta6

@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.5 Jan 9, 2024
@arturcic
Copy link
Member

arturcic commented Jan 9, 2024

🎉 This issue has been resolved in version 6.0.0-beta.5 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@arturcic
Copy link
Member

@christophwille may you give a try to the new beta?

@christophwille
Copy link
Author

I just did - works fine (the last stumbling block was Azure DevOps doing shallow checkouts these days by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants