Wrong working directory when building on TeamCity

[johannesegger]

When we run GitVersion 3.0.0-Beta1 on TeamCity, it clones parts of the repository to "_dynamicrepository" using GitPreparer.Prepare. When finished, this method returns the path to the prepared repository (i.e. "_dynamicrepository.git") and sets "_dynamicrepository" as working directory.
Now when the command line switch /exec is set, GitVersion executes the exe in the dynamic repository instead of the original repository as we would have expected. That then destroys some relative paths we are working with in the supplied exe file.
Can you confirm this or are we doing something wrong here?

[JakeGinnivan]

Thoughts @GeertvanHorrik @gep13

[GeertvanHorrik]

I think we need to split the directories internally for WorkingDirectory (source) and the GitDirectory. They might not be in the same place.

[JakeGinnivan]

Makes sense to me. Need to pull the execution stuff out of Program.cs so we can write some tests around it too. Will see if I can tackle over the weekend unless someone wants to jump in and do it first :)

[GeertvanHorrik]

Happy to help, but I really need a few features finished this week, too much PR / open source last weekend ;-)

Maybe later this week, but I might forget.

[gep13]

Makes sense to me 👍

[johannesegger]

We also recognized that the variables are wrong when using _dynamicrepository. They are calculated in the dynamic repository instead of the original one. Is it the same cause you think?

[GeertvanHorrik]

The best way to explain a problem is a failing unit test. Is that something you can create? Then we know exactly what issue to solve ;-)

[johannesegger]

I can't at the moment, because GitPreparer.Prepare directly uses Repository.Clone to create the _dynamicrepository, so I can't mock it, but maybe a function test is possible.

[johannesegger]

Ok, I can reproduce the issues with some powershell commands.
You can see that GitVersion runs the executable in the _dynamicrepository by running the following commands:

mkdir WorkingDirTest
cd .\WorkingDirTest
git init
git commit --allow-empty -m "Commit 1"
# use . as the remote repo, normally this is the https url
gitversion /url . /exec "powershell" /execargs "-Command pwd"
cd ..
rm -Force -Recurse .\WorkingDirTest

The output of the command is

Path
----
...\WorkingDirTest\_dynamicrepository

whereas it should be just ...\WorkingDirTest

[johannesegger]

To demonstrate that GitVersion calculates the variables based on the _dynamicrepository, run the following commands:

# create local repo
mkdir local
cd .\local
git init
git commit --allow-empty -m "Commit 1"

# create remote repo
git clone . ..\remote 
cd ..\remote
git commit --allow-empty -m "Commit 2" # someone pushes to the remote repo

# check versions in local repo
cd ..\local
gitversion /exec "powershell" /execargs '-Command echo $env:GitVersion_FullSemVer' # 0.1.0+0
gitversion /url ..\remote /exec "powershell" /execargs '-Command echo $env:GitVersion_FullSemVer' # 0.1.0+1
cd ..
rm -Force -Recurse local,remote

Both GitVersion commands should produce the same output.

[johannesegger]

I used GitVersion 3.0.0-Beta1 for both tests.

[GeertvanHorrik]

I think @JakeGinnivan already created a PR for this (see #399), but it's not merged into Beta1. I have reviewed the code, but just didn't find time to really try it out.