-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE]: dotnet tool install docs should not use an explicit --version arg #4244
Closed
2 tasks done
Labels
Milestone
Comments
I think this is a no issue for GitVersion.Tool, that's a dotnet tool thing, closing |
No, it's a documentation issue thing. Wish you wouldn't close an issue for errant docs 😒
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Artur ***@***.***>
Sent: Friday, October 4, 2024 12:33:47 PM
To: GitTools/GitVersion ***@***.***>
Cc: Craig E. Shea ***@***.***>; Author ***@***.***>
Subject: Re: [GitTools/GitVersion] [ISSUE]: dotnet tool install docs should not use an explicit --version arg (Issue #4244)
I think this is a no issue for GitVersion.Tool, that's a dotnet tool thing, closing
—
Reply to this email directly, view it on GitHub<#4244 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUTP2II5YOPOE2FP3AB6QLZZ27OXAVCNFSM6AAAAABPMB7ZY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGA3TEOBZGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I agree that we should update the installation instructions and either remove |
I'd rather remove it altogether, but if deemed helpful, add a note as I demonstrated in the original issue. Thanks for reopening.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Asbjørn Ulsberg ***@***.***>
Sent: Friday, October 4, 2024 7:18:54 PM
To: GitTools/GitVersion ***@***.***>
Cc: Craig E. Shea ***@***.***>; Author ***@***.***>
Subject: Re: [GitTools/GitVersion] [ISSUE]: dotnet tool install docs should not use an explicit --version arg (Issue #4244)
I agree that we should update the installation instructions<https://gitversion.net/docs/usage/cli/installation> and either remove --version altogether or at least set it to version 6 and not 5 as it is now.
—
Reply to this email directly, view it on GitHub<#4244 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUTP2ML6FZ4TGLNEA3BFSLZZ4O55AVCNFSM6AAAAABPMB7ZY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUG44DANRTGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
arturcic
added a commit
to arturcic/GitVersion
that referenced
this issue
Nov 12, 2024
arturcic
added a commit
that referenced
this issue
Nov 12, 2024
🎉 This issue has been resolved in version 6.0.5 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
GitVersion package
GitVersion.Tool
GitVersion version
6.x
Operating system
Windows
What are you seeing?
I recently installed the dotnet tool for this project following the instructions on the documentation site:
dotnet tool install --global GitVersion.Tool --version 5.*
.:dotnet tool -g gitversion
. Upon installation, runningdotnet gitversion /version
yields5.12.0...
.I initially forgot I had supplied a
--version
parameter when installing, hence the genesis of this issue.What is expected?
I was expecting v6.x which is the currently released version.I expect that the documentation would be updated to not include a--version
flag in the example. Perhaps a notice sidebar could be added to the docs to point people to the--version
flag if they need to install an older version of the GitVersion.Tools package, such as:Note
To install an older version of GitVersion.Tools, use the
--version
flag ofdotnet tool install
, e.g.dotnet tool install GitVersion.Tool --global --version 5.*
Steps to Reproduce
In the Visual Studio Terminal:
RepositoryFixture Test
No response
Output log or link to your CI build (if appropriate).
No response
The text was updated successfully, but these errors were encountered: