Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line args #428

Closed
JakeGinnivan opened this issue Apr 23, 2015 · 6 comments
Closed

Command line args #428

JakeGinnivan opened this issue Apr 23, 2015 · 6 comments
Labels

Comments

@JakeGinnivan
Copy link
Contributor

Just wanted to discuss while 3.0 has not been released.

Is it worth looking to see if we can improve the command line usage? There are a bunch of better parsing libraries and conventions like -s --short which git uses which could make the usage nicer.

We could to try keep compatibility have a translation to start which translates the command line args as they are now into the new args. Help will only show the new args.

What does everyone think? Is it worth investigating or not?

// @andreasohlund @SimonCropp @gep13 @GeertvanHorrik

@GeertvanHorrik
Copy link
Contributor

I think it's definitely worth investigating. It saves the code having to parse itself, it automatically supports /, -, -- and short and long codes. However... I know that it might also look like a big dependency. I don't care about it, but I know others do.

Maybe not for 3.0, if we are adding command line variables, it can be a smooth transition (add -u for -url, etc). We need to carefully thing this through instead of hurrying because 3.0 has to be released.

@asbjornu
Copy link
Member

asbjornu commented Jul 9, 2015

I think the current command line syntax in GitVersion is a mess (sorry for being frank), so cleaning it up to something a bit more conventional and familiar would be highly appreciated! 😄

If the dependency can be made on a source code level (and not as a NuGet binary reference), I'm all for it. Perhaps add it as a git submodule?

@GeertvanHorrik
Copy link
Contributor

We are aware of this ;-)

We are trying to find a set of commands that we can re-use amongst all tools. This way, no matter what tool you use, it should be very easy to get used to any tool you would like to use. It's still on the agenda.

@JakeGinnivan
Copy link
Contributor Author

Yeah, need to get v3 out the door. Then look at v4 for this sort of breaking change. Need to figure out how we could do some sort of compatibility mode to read legacy command lines and convert to the new one.

@asbjornu
Copy link
Member

asbjornu commented Jul 9, 2015

I agree that v3 should be shipped without this change. If the new command line argument syntax can be implemented in a backwards compatible way, it can be released as a minor v3 bump too; no need to wait for v4.

serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
AS of now, does not compile bco treat warnings as errors or similar project setting.
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 15, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 16, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 16, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 16, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 21, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 21, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 21, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 21, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 22, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 24, 2015
For GitTools#428.

This is the first part of the rewrite to better see where we're going.
I will implement this for three option verbs:

 * inspect
 * inject-buildserver
 * init
serra added a commit to openkas/GitVersion that referenced this issue Aug 24, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 24, 2015
serra added a commit to openkas/GitVersion that referenced this issue Aug 24, 2015
Taken from original program.cs
serra added a commit to openkas/GitVersion that referenced this issue Aug 24, 2015
@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2019
@stale stale bot closed this as completed Jul 29, 2019
This was referenced May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants