/updateassemblyinfo stopped working with 3.5.3

[pascalberger]

Using VSTS Extension which calls GitVersion with /output buildserver /nofetch /updateassemblyinfo true since the update to 3.5.3 this stopped updating the AssemblyInfo files.

While, with the exact command line arguments for GitVersion, with Version 3.5.1 the following entry was output in the log, this is missing with 3.5.3:

2016-05-17T13:22:53.6468468Z Executing GenerateBuildLogOutput for 'VsoAgent'.

[pascalberger]

@JakeGinnivan Any idea what might be causing this?

[pascalberger]

@asbjornu Might this come from your changes in ArgumentParser as part of https://github.com/GitTools/GitVersion/pull/856/files?

[pascalberger]

If I try locally the following is updating the AssemblyInfo:

giversion /output buildserver /updateassemblyinfo true

But as soon as I add the /nofetch argument it no longer works:

giversion /output buildserver /nofetch /updateassemblyinfo true

/nofetch added to the end of the command line again works:

giversion /output buildserver /updateassemblyinfo true /nofetch

Passing an explicit value to /nofetch also does work:

giversion /output buildserver /nofetch true /updateassemblyinfo true

So, seems to be an issue with argument parsing introduced in 3.5.3

[pascalberger]

VSTS task can be updated to set /nofetch true, but IMHO the breaking change for command line should be reverted in a 3.5.4 version. For 4.0 we can rethink the command line and introduce breaking changes.