Skip to content

Conversation

@JakeGinnivan
Copy link
Contributor

Please merge #101 first. This fixed #110

I will rebase once it is merged (there will be conflicts). Feel free to review in the mean time.

@JakeGinnivan
Copy link
Contributor Author

This is good to go again @andreasohlund @SimonCropp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need these as solution items?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly so readme is easily accessed so it gets updated when things are changed. Happy to revert though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah that is fine. was just curious

@SimonCropp
Copy link
Contributor

dont like approval tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really safe to assume?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for .net 4.0 and .net 4.5 pretty well. We can go into the registry and get the path too

But if our defaults don't work, you can specify the exe yourself with the /exe parameter

@JakeGinnivan
Copy link
Contributor Author

I deleted all the .orig files, not the actual .approved.txt

@SimonCropp
Copy link
Contributor

@JakeGinnivan ahh. ok

@JakeGinnivan
Copy link
Contributor Author

Rebased and fixed mentioned issues

andreasohlund added a commit that referenced this pull request Mar 28, 2014
@andreasohlund andreasohlund merged commit 5d16fac into GitTools:master Mar 28, 2014
JakeGinnivan pushed a commit to JakeGinnivan/GitVersion that referenced this pull request Mar 30, 2014
@JakeGinnivan JakeGinnivan deleted the ExecAndProjArguments branch January 6, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow GitVersion.exe to run build scripts/exes

3 participants