Added 'EnsureWixToolsetInstalled' BeforeTarget to GetVersionTask.targets

[forestb]

The Wix toolset does not trigger any of the following events/targets: CoreCompile;GetAssemblyVersion;GenerateNuspec;_GenerateRestoreProjectSpec, and as a result the GetVersion target never gets triggered, which means none of the environment variables are populated as a result of using MSBuild.

The EnsureWixToolsetInstalled is set as the default InitialTargets="EnsureWixToolsetInstalled" value for all Wix projects.

It would be hugely helpful to have the GitVersion variables seamlessly available as part of the build process for Wix projects!

RFR

[asbjornu]

This won't fail in non-Wix projects that don't have EnsureWixToolsetInstalled defined?

[forestb]

This won't fail in non-Wix projects that don't have EnsureWixToolsetInstalled defined?

Correct.

It used to be that GitVersion was more-incompatible with Wix until a fix was added in GitVersionTask v4.

After adding a reference to a Wix project using GitVersionTask v3.6.5 v.s.
After adding a reference to a Wix project using GitVersionTask v4.Beta

Now that a reference to GitVersionTask.targets is being added automatically, we just need to trigger the GetVersion target in order to populate the environment variables.

The addition I'm proposing only adds the condition, "Hey, I noticed the EnsureWixToolsetInstalled target is about to be executed; Let's execute GetVersion first."

It does not add a dependency, it only subscribes to that additional event if it's found.

[asbjornu]

Aha, I'm such an MSBuild noob that I misunderstood BeforeTargets to mean "run these targets before the current one", when it seems to mean exactly the opposite, which I understand won't break anything. Excellent! 👍