Add configuration parameter to format CommitDate #1305 #1306
Conversation
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of comments and this LGTM.
| } | ||
|
|
||
| [Test] | ||
| [TestCaseSource(nameof(CommitDateFormatTestCases))] |
There was a problem hiding this comment.
Since the test case formats are constant strings, please add them as regular [TestCase] attributes instead of the more complicated TestCaseData.
| public string CommitDate | ||
| { | ||
| get { return _semver.BuildMetaData.CommitDate.UtcDateTime.ToString("yyyy-MM-dd"); } | ||
| get { return _semver.BuildMetaData.CommitDate.UtcDateTime.ToString(_config.CommitDateFormat); } |
There was a problem hiding this comment.
Is it perhaps a good idea to pass in CultureInfo.InvariantCulture here, just to avoid potential i18n problems or is it a "feature" that the date can be formatted in the locale of the process GitVersion is run under?
|
I adopted your advices. Please review them. |
|
Perfect! Can you please do a git checkout master
git fetch upstream
git merge upstream/master
git checkout feature-commitdateformatconfigurable
git rebase master
git push --forceIf you don't have the remote If you have any questions, please don't hesitate to ask. Thanks! |
|
Sure I'll give it a try. Never done that before. |
ccHanibal
force-pushed
the
feature-commitdateformatconfigurable
branch
from
0a73167 to
dcc9c2b
Compare
|
@ccHanibal: Looks like that worked. Thanks! |
2 participants
As requested in #1305