Skip to content

Conversation

@JonCubed
Copy link
Contributor

@JonCubed JonCubed commented Oct 19, 2017

Pretty simple fix.

  • Will check if any of the remotes are origin if not takes the first remote as the one to keep
  • removes all other remotes

Should be flexible enough to handle most cases without maintaining a list. If branch to keep needs to be configurable we can add to yml and pass it into the GitParser

fixes #1311

@JonCubed JonCubed changed the title removes all duplicate repos if not origin WIP: removes all duplicate repos if not origin Oct 19, 2017
@JonCubed JonCubed force-pushed the feature/fix-cleanup-after-normalise branch from a2c18aa to 6193564 Compare October 19, 2017 06:44
@JonCubed JonCubed changed the title WIP: removes all duplicate repos if not origin removes all duplicate repos if not origin Oct 19, 2017
@JonCubed
Copy link
Contributor Author

good to go from my end

@asbjornu
Copy link
Member

This looks good, but could I please ask you to add a few of RepositoryFixture tests for this?

@JonCubed
Copy link
Contributor Author

sure I'll take a look tonight at it

@JakeGinnivan
Copy link
Contributor

Sorry to just drop by after ages not being around, I wonder if this is the right direction.

I think we should be striving for making less changes to the repo we are running against, rather than more.

For example, lets create a list of branches we are interested in when we start (which can de-dupe local/remote and give preference to remove), then work against that list rather than creating local branches?

@asbjornu
Copy link
Member

asbjornu commented Dec 6, 2017

Sounds like a plan, @JakeGinnivan. 👍

@JakeGinnivan
Copy link
Contributor

That origin1 removal is odd, didn't see that before. This looks like an improvement for the moment, while our goal should be to remove normalisation entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors when calculating for pull reqest

3 participants