-
Notifications
You must be signed in to change notification settings - Fork 662
Fix dotnet publish and VS2017 #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@asbjornu @gep13 @pascalberger can you review it and merge or talk about this pr ? |
|
Are we dogfooding or testing the changes that are made here in any way? |
|
I compile and use it in a production environment and it seems to be fine at the moment. |
|
@maikebing: What I meant was: Is GitVersion using the result in the build so if you actually broke something in this PR, we would notice it? |
|
@dazinator: Can you please take a look at this and whether it's something we want to merge? Aren't you dealing with many of the same issues in #1269? |
|
@asbjornu |
|
If there is any question and need me to do, please tell me, I hope to do better. |
|
Yeah this is covered in the netstandard pr, along with the other dotnet cli commands (restore, build, pack, etc). If its possible hold off merging this one then it will result in an easier merge of that other PR (less conflicts to resolve) whenever that happens. |
|
Closing this as the latest |
ILRepack is removed.
dotnet publish can publish you dotnet core projects !