Parallelize Unit Tests #1384
Closed
Parallelize Unit Tests #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
reviewed
Mar 12, 2018
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
This looks good, but I wonder why you've commented out the [assembly: Parallelizable(ParallelScope.Fixtures)]?
| @@ -0,0 +1,3 @@ | |||
| using NUnit.Framework; | |||
|
|
|||
| //[assembly: Parallelizable(ParallelScope.Fixtures)] No newline at end of file | |||
| @@ -0,0 +1,3 @@ | |||
| using NUnit.Framework; | |||
|
|
|||
| //[assembly: Parallelizable(ParallelScope.Fixtures)] No newline at end of file | |||
| @@ -0,0 +1,3 @@ | |||
| using NUnit.Framework; | |||
|
|
|||
| //[assembly: Parallelizable(ParallelScope.Fixtures)] No newline at end of file | |||
jkingry
force-pushed
the
feature/parallelize-unit-tests
branch
from
675a831 to
38b7c77
Compare
Contributor
Author
|
@asbjornu I messed up and committed the code I was running to double check the timing without the attributes. |
Member
|
@jkingry: I see. Unfortunately, bringing those back broke the build. Could you take a look at it, please? |
Contributor
Author
|
Yeah. I was afraid of that. Will look into it.
…On Mon, Mar 12, 2018 at 5:36 PM Asbjørn Ulsberg ***@***.***> wrote:
@jkingry <https://github.com/jkingry>: I see. Unfortunately, bringing
those back broke the build. Could you take a look at it, please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1384 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG0-Yv1KluS6ZLw9RetUstgfXiIs1ZWks5tdupVgaJpZM4SnPHh>
.
|
jkingry
force-pushed
the
feature/parallelize-unit-tests
branch
from
38b7c77 to
a1e6914
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like at least most NUnit fixtures can be run in parallel
Added assembly level attributes so that all fixtures run in parallel by default, can be disabled on a per-fixture basis. My tun all tests time went from 133 seconds to 67 seconds, 50% faster