Add NoUnix test category #1785
Closed
Add NoUnix test category #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoMono tests were being excluded when running on Unix.
Member
|
I fixed the unix tests for .net core in af4e947 and cleaned up the NoMono category attribute, now only the tests that really needs to be skipped on mono are marked. Thanks anyway for pointing to the right direction. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for excluding
NoMonocategorized tests really only checks if running on Unix. Instead, add a newNoUnixcategory for that and makeNoMonoactually mean skip Mono (by detecting a full framework test on Unix).See #1759 (comment) for discussion.