Working/repo directories with named configuration throw warning #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pianomanjh
force-pushed
the
bugfix/1808/named-config-exception
branch
from
a1017bb to
e263a31
Compare
asbjornu
changed the title
asbjornu
reviewed
Oct 18, 2019
pianomanjh
force-pushed
the
bugfix/1808/named-config-exception
branch
3 times, most recently
from
0d8e16d to
26beb85
Compare
Member
|
Sorry for not merging this earlier, @pianomanjh. Can you please take a look at why the build is failing and perhaps performing a rebase to get rid of my merge commits 855ec8c and 0702712? |
…sitory root are the same, do not throw a warning
…tive subdirectory of repo root, and working is repo root
…leSystem behavior as: a) it isn't case insensitive b) doesn't resolve/nomalize pathing constructs This caused the test in the previous test to erroneously pass
pianomanjh
force-pushed
the
bugfix/1808/named-config-exception
branch
from
0702712 to
e2fc1c4
Compare
Member
|
Thank you for your contributions, @pianomanjh! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a named configuration, and the working directory and repository root are the same, do not throw a warning.
For example, my repo root is
c:\projects\repoMy named config is at
c:\projects\repo\myConfig.ymlWhen running this command, from the repo root:
dotnet gitversion /config myConfig.ymlA warning is thrown, and versioning fails.
Additionally, the
TestFileSystemabstraction was broken, causing one of my tests to erroneously pass. This is due to:a) it isn't case insensitive
b) doesn't resolve/nomalize pathing constructs
I've only updated the
GitVersionCore.Testscopy. Let me know if you'd like me to fix the other copies of this. Ultimately, it would be better to go with a well-supported library for this, likeSystem.IO.AbstractionsFixes #1808.