Don't try to format non-format strings. #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many consumers are doing a log.Info("somestring") and have no desire to trigger formatstring behavior. This change allows them to use '{' or '}' without running into formatting exceptions.
Member
|
@eric-winkler thank you very much for having a lóok. LGTM. Merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many consumers are doing a
log.Info("somestring")and have no desire to trigger formatstring behavior. This change allows them to use{or}without running into formatting exceptions.Fixes #1875 - This was triggered by attempts to log remote tips using the
<rev>^{}revision syntax.