Skip to content

WIP: Feature/informationalversion #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asbjornu merged 5 commits into from
Jan 17, 2020
Merged

WIP: Feature/informationalversion #2051

asbjornu merged 5 commits into from
Jan 17, 2020

Conversation

@mgnslndh
Copy link
Contributor

@mgnslndh mgnslndh commented Jan 16, 2020 •
edited
Loading

This is a PR that will change the name of the property DefaultInformationalVersion of SemanticVersionFormatValues to InformationalVersion to keep it in sync with VersionVariables and the documentation. DefaultInformationalVersion will be kept around for backwards compatibility until it can be removed.

The property DefaultInformationalVersion has been marked with the ObsoleteAttribute. Using it in custom formatting in the configuration file will result in a warning being logged.

Feedback appreciated!

See #2026 for the background to this PR.

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Jan 16, 2020

Should there be a IVersionVariables interface that both VersionVariables and SemanticVersionFormatValues should implement to force them to be in sync. The documentation kind of implies that the VersionVariables can be used for custom formatting in the configuration file, but really it is the SemanticVersionFormatValues type that is being used for that purpose.

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Jan 16, 2020

Also, I minor change was made to how VersionVariables.AvailableVariables sorts the variable names. Running tests with Swedish regional settings caused the WixFileTests approval test to fail because of sorting order.

@mgnslndh mgnslndh requested a review from asbjornu January 16, 2020 21:51
asbjornu
asbjornu requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the build failing and the PR having conflicts that needs to be resolved, this looks great!

@mgnslndh mgnslndh requested a review from asbjornu January 17, 2020 17:28
@asbjornu asbjornu merged commit 518ba2d into GitTools:master Jan 17, 2020
@asbjornu
Copy link
Member

asbjornu commented Jan 17, 2020

Thank you so much for your contributions, @mgnslndh! 🙏

@asbjornu asbjornu mentioned this pull request Jan 17, 2020
Closed
@arturcic arturcic added this to the 5.1.4 milestone Jan 18, 2020
@mgnslndh mgnslndh deleted the feature/informationalversion branch January 18, 2020 16:35
@asbjornu asbjornu mentioned this pull request Feb 18, 2020
Closed
@asbjornu asbjornu mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgnslndh @asbjornu @arturcic