Skip to content

Conversation

@tpaxatb
Copy link
Contributor

@tpaxatb tpaxatb commented Mar 10, 2020

The repository opened for use to do versioning should be the Project Directory, not the DotGit directory.
Also fixes it so the project directory used is based on the DynamicGitDirectory if it is a dynamic repo.

Fixes #2165. Closes #1848.

@tpaxatb tpaxatb mentioned this pull request Mar 10, 2020
@asbjornu
Copy link
Member

Since this seems to tackle the same problems as #1848, would it be possible for you to incorporate the tests added there in this PR? I'm not confident that we have sufficient coverage for this, for the reasons outlined in #2165 (comment).

@tpaxatb tpaxatb force-pushed the master branch 2 times, most recently from 0caf832 to 4b4cb5e Compare March 19, 2020 15:49
The repository opened for use to do versioning should be the Project Directory, not the DotGit directory.
Also fixes it so the project directory used is based on the DynamicGitDirectory if it is a dynamic repo.
@arturcic
Copy link
Member

Closing this one in favor of #2281

@arturcic arturcic closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Worktrees incorrectly calculated

3 participants