Issue #2167 Generated files not soon enough #2168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for the generated files to be available during the first pass, they must be generated before the pass1. In addition, the files that are generated must be added to the _GeneratedCodeFiles items.
Member
|
Currently the tests we have don't cover the order of the tasks, and to be honest I don't know if we can automate that. |
Member
|
I'm more concerned with the task still working at all than the order being as expected. As long as we have tests that dogfood GitVersionTask and check the generated version variables, I think we're good. |
Member
|
We do have tests that run the msbuild artifact and checks the generated version |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for the generated files to be available during the first pass,
they must be generated before the pass1. In addition, the files that are
generated must be added to the
_GeneratedCodeFilesitems.Fixes #2167.