Skip to content

GH-2225 use FileSystemGlobbing to resolve AsemblyInfo to be updated #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturcic merged 4 commits into from
Apr 30, 2020
Merged

GH-2225 use FileSystemGlobbing to resolve AsemblyInfo to be updated #2240

arturcic merged 4 commits into from
Apr 30, 2020

Conversation

@arturcic
Copy link
Member

@arturcic arturcic commented Apr 23, 2020

No description provided.

@arturcic arturcic linked an issue Apr 23, 2020 that may be closed by this pull request
[Bug] Azure DevOps UseGitVersion@5 task and GitVersion 5.2.4 produces an error "AssemblyInfoFilename file not found at null" when UpdateAssemblyInfo: true is set #2225
Closed
@arturcic arturcic requested a review from asbjornu April 23, 2020 10:29
asbjornu
asbjornu approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the use of AssemblyInfoContext over several parameters. Would be great to roll out that design throughout the codebase.

asbjornu
asbjornu requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: Should we perhaps add a test for the globbing, to see that it works and doesn't regress in the future?

@arturcic
Copy link
Member Author

arturcic commented Apr 23, 2020

I really like the use of AssemblyInfoContext over several parameters. Would be great to roll out that design throughout the codebase.

At least for VersionConverters I have created Context classes

@arturcic
Copy link
Member Author

arturcic commented Apr 23, 2020

Just one question: Should we perhaps add a test for the globbing, to see that it works (and doesn't regress in the future?

I will

@arturcic arturcic force-pushed the fix/GH-2225 branch 3 times, most recently from b68354b to e4808bb Compare April 30, 2020 05:56
@arturcic arturcic requested a review from asbjornu April 30, 2020 06:22
@arturcic arturcic force-pushed the fix/GH-2225 branch 2 times, most recently from 53b4ffe to 7818e63 Compare April 30, 2020 09:53
asbjornu
asbjornu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @arturcic! 👍

@arturcic
Copy link
Member Author

arturcic commented Apr 30, 2020

Great work, @arturcic! 👍

Thanks

@arturcic arturcic merged commit a6fb735 into GitTools:master Apr 30, 2020
@arturcic arturcic deleted the fix/GH-2225 branch April 30, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@arturcic @asbjornu