Issue #2257 Ensure Valid Wix Version File #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
reviewed
May 6, 2020
| var root = doc.DocumentElement; | ||
| doc.InsertBefore(xmlDecl, root); | ||
|
|
||
| fileSystem.Delete(wixVersionFile); |
Member
There was a problem hiding this comment.
Should this always be deleted, unconditionally?
Author
There was a problem hiding this comment.
I would say yes, as the entire file is fully re-created (no update). This way it is ensured that the written file does not contain garbage after the expected content.
Maybe one could check whether the file exists, which is in my opinion useless as Delete() does not throw when the file does not exist.
asbjornu
approved these changes
May 8, 2020
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
Since all tests pass and the number of tests increases with this PR, I don't see why it shouldn't be merged. :)
Member
|
Thanks for your contributions, @tcs-devel! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2257
Note 1: The first commit would also fix the issue but does not the IFileStream as an abstraction layer. The second commit does.
Note 2: The added unit test also succeeds without the fix :(. As far as I saw, this is because the
OpenWrite()function of theTestFileSystemclass does not behave the way as it documented in https://docs.microsoft.com/en-us/dotnet/api/system.io.file.openwrite?view=netcore-3.1 in regards to existing files.